1
0
mirror of https://github.com/Rogiel/l2jserver2 synced 2025-12-06 07:32:46 +00:00

Code cleanup

Signed-off-by: Rogiel <rogiel@rogiel.com>
This commit is contained in:
2011-05-14 13:35:12 -03:00
parent 4b9d52e724
commit 1e52e960f5
15 changed files with 34 additions and 14 deletions

View File

@@ -21,8 +21,7 @@ public abstract class AbstractGradeAArmorTemplate extends ArmorTemplate
@Override @Override
public void penalty(Equiper user) { public void penalty(Equiper user) {
if (!(user instanceof Levelable) && !(user instanceof Castable) if (!(user instanceof Levelable) && !(user instanceof Castable))
&& !(user instanceof Equiper))
return; return;
final Levelable levelable = (Levelable) user; final Levelable levelable = (Levelable) user;
final Castable castable = (Castable) user; final Castable castable = (Castable) user;

View File

@@ -145,6 +145,7 @@ public class Lineage2Connection {
/** /**
* Get the channel * Get the channel
*
* @return the channel * @return the channel
*/ */
public Channel getChannel() { public Channel getChannel() {

View File

@@ -7,8 +7,8 @@ import com.google.inject.assistedinject.FactoryModuleBuilder;
import com.l2jserver.model.id.object.allocator.BitSetIDAllocator; import com.l2jserver.model.id.object.allocator.BitSetIDAllocator;
import com.l2jserver.model.id.object.allocator.IDAllocator; import com.l2jserver.model.id.object.allocator.IDAllocator;
import com.l2jserver.model.id.object.factory.CharacterIDFactory; import com.l2jserver.model.id.object.factory.CharacterIDFactory;
import com.l2jserver.model.id.object.factory.ItemIDFactory;
import com.l2jserver.model.id.object.factory.CharacterIDFactory.CharacterIDGuiceFactory; import com.l2jserver.model.id.object.factory.CharacterIDFactory.CharacterIDGuiceFactory;
import com.l2jserver.model.id.object.factory.ItemIDFactory;
import com.l2jserver.model.id.object.factory.ItemIDFactory.ItemIDGuiceFactory; import com.l2jserver.model.id.object.factory.ItemIDFactory.ItemIDGuiceFactory;
import com.l2jserver.model.id.template.factory.CharacterTemplateIDFactory; import com.l2jserver.model.id.template.factory.CharacterTemplateIDFactory;
import com.l2jserver.model.id.template.factory.ItemTemplateIDFactory; import com.l2jserver.model.id.template.factory.ItemTemplateIDFactory;

View File

@@ -27,6 +27,6 @@ public class CharacterTemplateID extends TemplateID<CharacterTemplate> {
@Override @Override
public CharacterTemplate getTemplate() { public CharacterTemplate getTemplate() {
return (CharacterTemplate) templateService.getTemplate(this); return templateService.getTemplate(this);
} }
} }

View File

@@ -7,8 +7,7 @@ import com.l2jserver.model.template.ItemTemplate;
import com.l2jserver.service.game.template.TemplateService; import com.l2jserver.service.game.template.TemplateService;
/** /**
* An {@link TemplateID} instance representing an {@link ItemTemplate} * An {@link TemplateID} instance representing an {@link ItemTemplate} object
* object
* *
* @author <a href="http://www.rogiel.com">Rogiel</a> * @author <a href="http://www.rogiel.com">Rogiel</a>
*/ */
@@ -26,6 +25,6 @@ public class ItemTemplateID extends TemplateID<ItemTemplate> {
@Override @Override
public ItemTemplate getTemplate() { public ItemTemplate getTemplate() {
return (ItemTemplate) templateService.getTemplate(this); return templateService.getTemplate(this);
} }
} }

View File

@@ -7,8 +7,7 @@ import com.l2jserver.model.template.SkillTemplate;
import com.l2jserver.service.game.template.TemplateService; import com.l2jserver.service.game.template.TemplateService;
/** /**
* An {@link TemplateID} instance representing an {@link SkillTemplate} * An {@link TemplateID} instance representing an {@link SkillTemplate} object
* object
* *
* @author <a href="http://www.rogiel.com">Rogiel</a> * @author <a href="http://www.rogiel.com">Rogiel</a>
*/ */
@@ -26,6 +25,6 @@ public class SkillTemplateID extends TemplateID<SkillTemplate> {
@Override @Override
public SkillTemplate getTemplate() { public SkillTemplate getTemplate() {
return (SkillTemplate) templateService.getTemplate(this); return templateService.getTemplate(this);
} }
} }

View File

@@ -18,6 +18,7 @@ public abstract class AbstractTemplate<T> implements Template<T> {
/** /**
* Creates a new instance * Creates a new instance
*
* @param id * @param id
*/ */
protected AbstractTemplate(TemplateID<?> id) { protected AbstractTemplate(TemplateID<?> id) {

View File

@@ -191,6 +191,7 @@ public abstract class AbstractActor extends AbstractObject implements Actor {
/** /**
* @return the active effects on this actor * @return the active effects on this actor
*/ */
@Override
public ActorEffects getEffects() { public ActorEffects getEffects() {
return effects; return effects;
} }

View File

@@ -13,10 +13,12 @@ public abstract class AbstractObject implements WorldObject {
*/ */
protected ObjectID<?> id; protected ObjectID<?> id;
@Override
public ObjectID<?> getID() { public ObjectID<?> getID() {
return id; return id;
} }
@Override
public void setID(ObjectID<?> id) { public void setID(ObjectID<?> id) {
if (this.id != null) if (this.id != null)
throw new IllegalStateException("ID is already set!"); throw new IllegalStateException("ID is already set!");

View File

@@ -25,74 +25,92 @@ public class CharacterCalculatedAttributes implements CharacterAttributes {
this.baseAttributes = this.character.getBaseAttributes(); this.baseAttributes = this.character.getBaseAttributes();
} }
@Override
public int getIntelligence() { public int getIntelligence() {
return baseAttributes.getIntelligence(); return baseAttributes.getIntelligence();
} }
@Override
public int getStrength() { public int getStrength() {
return baseAttributes.getStrength(); return baseAttributes.getStrength();
} }
@Override
public int getConcentration() { public int getConcentration() {
return baseAttributes.getConcentration(); return baseAttributes.getConcentration();
} }
@Override
public int getMentality() { public int getMentality() {
return baseAttributes.getMentality(); return baseAttributes.getMentality();
} }
@Override
public int getDexterity() { public int getDexterity() {
return baseAttributes.getDexterity(); return baseAttributes.getDexterity();
} }
@Override
public int getWitness() { public int getWitness() {
return baseAttributes.getWitness(); return baseAttributes.getWitness();
} }
@Override
public int getPhysicalAttack() { public int getPhysicalAttack() {
return baseAttributes.getPhysicalAttack(); return baseAttributes.getPhysicalAttack();
} }
@Override
public int getMagicalAttack() { public int getMagicalAttack() {
return baseAttributes.getMagicalAttack(); return baseAttributes.getMagicalAttack();
} }
@Override
public int getPhysicalDefense() { public int getPhysicalDefense() {
return baseAttributes.getPhysicalDefense(); return baseAttributes.getPhysicalDefense();
} }
@Override
public int getMagicalDefense() { public int getMagicalDefense() {
return baseAttributes.getMagicalDefense(); return baseAttributes.getMagicalDefense();
} }
@Override
public int getAttackSpeed() { public int getAttackSpeed() {
return baseAttributes.getAttackSpeed(); return baseAttributes.getAttackSpeed();
} }
@Override
public int getCastSpeed() { public int getCastSpeed() {
return baseAttributes.getCastSpeed(); return baseAttributes.getCastSpeed();
} }
@Override
public int getAccuracy() { public int getAccuracy() {
return baseAttributes.getAccuracy(); return baseAttributes.getAccuracy();
} }
@Override
public int getCriticalChance() { public int getCriticalChance() {
return baseAttributes.getCriticalChance(); return baseAttributes.getCriticalChance();
} }
@Override
public int getEvasionChance() { public int getEvasionChance() {
return baseAttributes.getEvasionChance(); return baseAttributes.getEvasionChance();
} }
@Override
public int getMoveSpeed() { public int getMoveSpeed() {
return baseAttributes.getMoveSpeed(); return baseAttributes.getMoveSpeed();
} }
@Override
public int getMaxWeigth() { public int getMaxWeigth() {
return baseAttributes.getMaxWeigth(); return baseAttributes.getMaxWeigth();
} }
@Override
public boolean canCraft() { public boolean canCraft() {
return baseAttributes.canCraft(); return baseAttributes.canCraft();
} }

View File

@@ -44,6 +44,7 @@ public class WorldEventDispatcherImpl implements WorldEventDispatcher {
}, 0, 50); }, 0, 50);
} }
@Override
public void dispatch(WorldEvent event) { public void dispatch(WorldEvent event) {
log.debug("Queing dispatch for event {}", event); log.debug("Queing dispatch for event {}", event);
events.add(event); events.add(event);

View File

@@ -9,7 +9,7 @@ import com.l2jserver.util.transformer.Transformer;
*/ */
public class DoubleTransformer implements Transformer<Double> { public class DoubleTransformer implements Transformer<Double> {
public static final DoubleTransformer SHARED_INSTANCE = new DoubleTransformer(); public static final DoubleTransformer SHARED_INSTANCE = new DoubleTransformer();
@Override @Override
public String transform(Double value) { public String transform(Double value) {
return Double.toString(value); return Double.toString(value);

View File

@@ -9,7 +9,7 @@ import com.l2jserver.util.transformer.Transformer;
*/ */
public class IntegerTransformer implements Transformer<Integer> { public class IntegerTransformer implements Transformer<Integer> {
public static final IntegerTransformer SHARED_INSTANCE = new IntegerTransformer(); public static final IntegerTransformer SHARED_INSTANCE = new IntegerTransformer();
@Override @Override
public String transform(Integer value) { public String transform(Integer value) {
return Integer.toString(value); return Integer.toString(value);

View File

@@ -9,7 +9,7 @@ import com.l2jserver.util.transformer.Transformer;
*/ */
public class ShortTransformer implements Transformer<Short> { public class ShortTransformer implements Transformer<Short> {
public static final ShortTransformer SHARED_INSTANCE = new ShortTransformer(); public static final ShortTransformer SHARED_INSTANCE = new ShortTransformer();
@Override @Override
public String transform(Short value) { public String transform(Short value) {
return Short.toString(value); return Short.toString(value);

View File

@@ -9,7 +9,6 @@ import com.google.inject.Guice;
import com.google.inject.Injector; import com.google.inject.Injector;
import com.l2jserver.db.dao.DAOModuleMySQL5; import com.l2jserver.db.dao.DAOModuleMySQL5;
import com.l2jserver.model.id.ID; import com.l2jserver.model.id.ID;
import com.l2jserver.model.id.factory.IDFactoryModule;
import com.l2jserver.model.id.object.CharacterID; import com.l2jserver.model.id.object.CharacterID;
import com.l2jserver.model.id.object.factory.CharacterIDFactory; import com.l2jserver.model.id.object.factory.CharacterIDFactory;
import com.l2jserver.model.world.L2Character; import com.l2jserver.model.world.L2Character;