Fixed compiler warnings

Signed-off-by: Rogiel <rogiel@rogiel.com>

src/dao/mysql5/com/l2jserver/db/dao/mysql5/MySQL5ClanDAO.java

@@ -50,6 +50,7 @@ public class MySQL5ClanDAO extends AbstractMySQL5DAO<Clan, ClanID> implements
 	/**
 	 * The {@link CharacterID} factory
 	 */
+	@SuppressWarnings("unused")
 	private final CharacterIDProvider charIdFactory;
 
 	/**

src/main/java/com/l2jserver/game/net/codec/Lineage2FrameDecoder.java

@@ -23,8 +23,6 @@ import org.jboss.netty.buffer.ChannelBuffers;
 import org.jboss.netty.channel.Channel;
 import org.jboss.netty.channel.ChannelHandlerContext;
 import org.jboss.netty.handler.codec.frame.FrameDecoder;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * This decoder parses Lineage II frames. Each frame is has a header of 2 bytes
@@ -35,9 +33,6 @@ import org.slf4j.LoggerFactory;
 public class Lineage2FrameDecoder extends FrameDecoder {
 	private static final int HEADER_SIZE = 2;
 
-	private static final Logger logger = LoggerFactory
-			.getLogger(Lineage2FrameDecoder.class);
-
 	@Override
 	protected Object decode(ChannelHandlerContext ctx, Channel channel,
 			ChannelBuffer oldBuffer) throws Exception {

src/main/java/com/l2jserver/game/net/codec/Lineage2PacketWriter.java

@@ -23,8 +23,6 @@ import org.jboss.netty.buffer.ChannelBuffers;
 import org.jboss.netty.channel.Channel;
 import org.jboss.netty.channel.ChannelHandlerContext;
 import org.jboss.netty.handler.codec.oneone.OneToOneEncoder;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 import com.l2jserver.game.net.Lineage2Connection;
 import com.l2jserver.game.net.packet.ServerPacket;
@@ -42,12 +40,6 @@ public class Lineage2PacketWriter extends OneToOneEncoder {
 	 */
 	public static final String HANDLER_NAME = "packet.writer";
 
-	/**
-	 * The logger
-	 */
-	private static final Logger log = LoggerFactory
-			.getLogger(Lineage2PacketWriter.class);
-
 	/**
 	 * The active Lineage 2 connection
 	 */

src/main/java/com/l2jserver/game/net/packet/client/CharacterRequestActionUse.java

@@ -80,7 +80,9 @@ public class CharacterRequestActionUse extends AbstractClientPacket {
 		}
 	}
 
+	@SuppressWarnings("unused")
 	private boolean ctrlPressed;
+	@SuppressWarnings("unused")
 	private boolean shiftPressed;
 
 	@Inject

src/main/java/com/l2jserver/game/net/packet/client/CharacterValidatePositionPacket.java

@@ -41,6 +41,7 @@ public class CharacterValidatePositionPacket extends AbstractClientPacket {
 	private final CharacterService charService;
 
 	private Point point;
+	@SuppressWarnings("unused")
 	private int extra; // vehicle id
 
 	@Inject

src/main/java/com/l2jserver/game/net/packet/client/RequestShortcutRegistry.java

@@ -48,14 +48,20 @@ public class RequestShortcutRegistry extends AbstractClientPacket {
 	/**
 	 * The shortcut type
 	 */
+	@SuppressWarnings("unused")
 	private int type;
 	/**
 	 * The shortcut ID
 	 */
+	@SuppressWarnings("unused")
 	private int id;
+	@SuppressWarnings("unused")
 	private int slot;
+	@SuppressWarnings("unused")
 	private int page;
+	@SuppressWarnings("unused")
 	private int lvl;
+	@SuppressWarnings("unused")
 	private int characterType;
 
 	@Override

src/main/java/com/l2jserver/model/world/actor/calculator/ActorCalculator.java

@@ -22,6 +22,7 @@ import com.l2jserver.model.world.Actor;
  * @author <a href="http://www.rogiel.com">Rogiel</a>
  */
 public class ActorCalculator {
+	@SuppressWarnings("unused")
 	private final Actor actor;
 
 	public ActorCalculator(Actor actor) {

src/main/java/com/l2jserver/service/AbstractService.java

@@ -41,6 +41,7 @@ public abstract class AbstractService implements Service {
 			this.running = true;
 		} catch (ServiceStartException e) {
 			this.running = false;
+			throw e;
 		}
 	}
 

src/main/java/com/l2jserver/service/admin/AdministratorServiceImpl.java

@@ -18,6 +18,7 @@ package com.l2jserver.service.admin;
 
 import java.util.List;
 
+import com.l2jserver.model.id.object.CharacterID;
 import com.l2jserver.model.world.L2Character;
 import com.l2jserver.service.AbstractService;
 
@@ -27,7 +28,8 @@ import com.l2jserver.service.AbstractService;
  */
 public class AdministratorServiceImpl extends AbstractService implements
 		AdministratorService {
-	private List<L2Character> online;
+	@SuppressWarnings("unused")
+	private List<CharacterID> online;
 	
 	@Override
 	public void command(L2Character character, String command, String... args) {

src/main/java/com/l2jserver/service/game/AttackServiceImpl.java

@@ -39,6 +39,7 @@ public class AttackServiceImpl extends AbstractService implements AttackService
 	 * The {@link WorldEventDispatcher} is used to dispatch attack events to the
 	 * world
 	 */
+	@SuppressWarnings("unused")
 	private final WorldEventDispatcher eventDispatcher;
 
 	@Inject
@@ -66,10 +67,12 @@ public class AttackServiceImpl extends AbstractService implements AttackService
 		/**
 		 * The attacker
 		 */
+		@SuppressWarnings("unused")
 		private final Actor attacker;
 		/**
 		 * The target
 		 */
+		@SuppressWarnings("unused")
 		private final Actor target;
 
 		public AttackCallable(Actor attacker, Actor target) {

src/main/java/com/l2jserver/service/game/ai/AIServiceImpl.java

@@ -40,18 +40,22 @@ public class AIServiceImpl extends AbstractService implements AIService {
 	/**
 	 * The {@link WorldService}
 	 */
+	@SuppressWarnings("unused")
 	private final WorldService worldService;
 	/**
 	 * The {@link WorldService} event dispatcher
 	 */
+	@SuppressWarnings("unused")
 	private final WorldEventDispatcher eventDispatcher;
 	/**
 	 * The {@link ThreadService}
 	 */
+	@SuppressWarnings("unused")
 	private final ThreadService threadService;
 	/**
 	 * The {@link NetworkService}
 	 */
+	@SuppressWarnings("unused")
 	private final NetworkService networkService;
 
 	@Inject

src/main/java/com/l2jserver/service/game/npc/NPCServiceImpl.java

@@ -56,6 +56,7 @@ public class NPCServiceImpl extends AbstractService implements NPCService {
 	/**
 	 * The {@link CharacterService}
 	 */
+	@SuppressWarnings("unused")
 	private final CharacterService characterService;
 
 	/**

src/main/java/com/l2jserver/service/game/spawn/SpawnServiceImpl.java

@@ -16,9 +16,6 @@
  */
 package com.l2jserver.service.game.spawn;
 
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
 import com.google.common.base.Preconditions;
 import com.google.inject.Inject;
 import com.l2jserver.game.net.Lineage2Connection;
@@ -50,11 +47,6 @@ import com.l2jserver.util.dimensional.Point;
  */
 @Depends({ WorldService.class })
 public class SpawnServiceImpl extends AbstractService implements SpawnService {
-	/**
-	 * The logger
-	 */
-	private final Logger log = LoggerFactory.getLogger(this.getClass());
-
 	/**
 	 * The {@link WorldService}
 	 */

src/main/java/com/l2jserver/util/calculator/PercentFunction.java

@@ -16,13 +16,15 @@
  */
 package com.l2jserver.util.calculator;
 
+import com.l2jserver.model.world.Actor;
+
 /**
  * This function performs a multiplication: <blockquote><code>chain value *
  * (value / 100)</code></blockquote>
  * 
  * @author <a href="http://www.rogiel.com">Rogiel</a>
  */
-public class PercentFunction extends MultiplicationFunction {
+public class PercentFunction<O extends Actor> extends MultiplicationFunction<O> {
 	/**
 	 * The value
 	 */

src/main/java/com/l2jserver/util/jaxb/CharacterTemplateIDAdapter.java

@@ -21,11 +21,10 @@ import javax.xml.bind.annotation.adapters.XmlAdapter;
 import com.google.inject.Inject;
 import com.l2jserver.model.id.template.CharacterTemplateID;
 import com.l2jserver.model.id.template.provider.CharacterTemplateIDProvider;
-import com.l2jserver.model.id.template.provider.ItemTemplateIDProvider;
 import com.l2jserver.model.world.character.CharacterClass;
 
 /**
- * TODO this should use an {@link ItemTemplateIDProvider}!
+ * This class is an JAXB Adapter for {@link CharacterTemplateIDProvider}
  * 
  * @author <a href="http://www.rogiel.com">Rogiel</a>
  */

src/main/java/com/l2jserver/util/jaxb/ItemTemplateIDAdapter.java

@@ -23,7 +23,7 @@ import com.l2jserver.model.id.template.ItemTemplateID;
 import com.l2jserver.model.id.template.provider.ItemTemplateIDProvider;
 
 /**
- * TODO this should use an {@link ItemTemplateIDProvider}!
+ * This class is an JAXB Adapter for {@link ItemTemplateIDProvider}
  * 
  * @author <a href="http://www.rogiel.com">Rogiel</a>
  */
@@ -43,7 +43,7 @@ public class ItemTemplateIDAdapter extends XmlAdapter<Integer, ItemTemplateID> {
 	public ItemTemplateID unmarshal(Integer v) throws Exception {
 		if (v == 0)
 			return null;
-		if(provider == null)
+		if (provider == null)
 			return new ItemTemplateID(v, null);
 		return provider.createID(v);
 	}

src/main/java/com/l2jserver/util/jaxb/NPCTemplateIDAdapter.java

@@ -20,11 +20,10 @@ import javax.xml.bind.annotation.adapters.XmlAdapter;
 
 import com.google.inject.Inject;
 import com.l2jserver.model.id.template.NPCTemplateID;
-import com.l2jserver.model.id.template.provider.ItemTemplateIDProvider;
 import com.l2jserver.model.id.template.provider.NPCTemplateIDProvider;
 
 /**
- * TODO this should use an {@link ItemTemplateIDProvider}!
+ * This class is an JAXB Adapter for {@link NPCTemplateIDProvider}
  * 
  * @author <a href="http://www.rogiel.com">Rogiel</a>
  */

src/main/java/com/l2jserver/util/jaxb/TeleportationTemplateIDAdapter.java

@@ -20,11 +20,10 @@ import javax.xml.bind.annotation.adapters.XmlAdapter;
 
 import com.google.inject.Inject;
 import com.l2jserver.model.id.template.TeleportationTemplateID;
-import com.l2jserver.model.id.template.provider.ItemTemplateIDProvider;
 import com.l2jserver.model.id.template.provider.TeleportationTemplateIDProvider;
 
 /**
- * TODO this should use an {@link ItemTemplateIDProvider}!
+ * This class is an JAXB Adapter for {@link TeleportationTemplateIDProvider}
  * 
  * @author <a href="http://www.rogiel.com">Rogiel</a>
  */

src/test/java/com/l2jserver/service/game/scripting/impl/compiled/PrecompiledScriptCompilerTest.java

@@ -36,8 +36,10 @@ public class PrecompiledScriptCompilerTest {
 	@Test
 	public void testCompileIterableOfFile() {
 		final PrecompiledScriptCompiler compiler = new PrecompiledScriptCompiler();
+		@SuppressWarnings("unchecked")
 		final CompilationResult result = compiler.compile(FileUtils.listFiles(
-				new File("target/scripts/script/template"), new String[] { "class" }, true));
+				new File("target/scripts/script/template"),
+				new String[] { "class" }, true));
 		System.out.println(result.getCompiledClasses()[0]);
 	}
 }

src/tool/java/com/l2jserver/model/template/NPCOldTemplateConverter.java

@@ -81,6 +81,7 @@ public class NPCOldTemplateConverter {
 
 	private static String[] generateJavaClass(ResultSet rs) throws SQLException {
 		String npcName = "";
+		@SuppressWarnings("unused")
 		String npcClass = "";
 		String npcTitle = "";
 		String npcType = "";
@@ -189,7 +190,7 @@ public class NPCOldTemplateConverter {
 			return "";
 		if (l2j.contains("VillageMaster"))
 			return (l2j.replaceAll("VillageMaster", "") + "VillageMaster");
-		if(l2j.contains("Npc"))
+		if (l2j.contains("Npc"))
 			l2j = l2j.replaceAll("Npc", "");
 		return l2j;
 	}