mirror of
https://github.com/Rogiel/l2jserver2
synced 2025-12-06 07:32:46 +00:00
Fixed test-smells
This commit is contained in:
@@ -70,8 +70,8 @@ public class CharacterIDProviderTest {
|
||||
public void testCreateID() {
|
||||
final ID<Integer> id1 = charIdFactory.createID();
|
||||
final ID<Integer> id2 = charIdFactory.createID();
|
||||
Assert.assertNotNull(id1);
|
||||
Assert.assertFalse(id1.equals(id2));
|
||||
Assert.assertNotNull("Must return a valid ID.", id1);
|
||||
Assert.assertFalse("Must allocate unique IDs.", id1.equals(id2));
|
||||
}
|
||||
|
||||
/**
|
||||
@@ -82,6 +82,7 @@ public class CharacterIDProviderTest {
|
||||
final CharacterID id1 = charIdFactory.createID();
|
||||
Assert.assertNotNull(id1);
|
||||
charIdFactory.destroy(id1);
|
||||
Assert.assertNull(charIdFactory.resolveID(id1.getID()));
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
@@ -78,8 +78,7 @@ public class WorldServiceImplTest {
|
||||
*/
|
||||
@Test(expected = NullPointerException.class)
|
||||
public void testAddNullId() {
|
||||
final L2Character character = new L2Character(null);
|
||||
world.add(character);
|
||||
world.add(null);
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user